unchained/mission-control
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: enhance error handling and optimize user profile fetching logic

Browse Source
This commit is contained in:
Abhimanyu Saharan
2026-02-10 00:50:43 +05:30
parent ba73ce8bfd
commit 822b13e6eb
1 changed files with 42 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
backend/app/core/auth.py
View File

@@ -7,6 +7,7 @@ from dataclasses import dataclass
from time import monotonic from time import monotonic
from typing import TYPE_CHECKING, Literal from typing import TYPE_CHECKING, Literal
import httpx
import jwt import jwt
from clerk_backend_api import Clerk from clerk_backend_api import Clerk
from clerk_backend_api.models.clerkerrors import ClerkErrors from clerk_backend_api.models.clerkerrors import ClerkErrors
@@ -323,11 +324,22 @@ async def _fetch_clerk_profile(clerk_user_id: str) -> tuple[str | None, str | No
secret_kind, secret_kind,
response_body, response_body,
) )
except Exception: except httpx.TimeoutException as exc:
logger.warning( logger.warning(
"auth.clerk.profile.fetch_failed clerk_user_id=%s reason=sdk_exception", "auth.clerk.profile.fetch_failed clerk_user_id=%s reason=timeout "
"server_url=%s secret_kind=%s error=%s",
clerk_user_id, clerk_user_id,
exc_info=True, server_url,
secret_kind,
str(exc) or exc.__class__.__name__,
)
except Exception as exc:
logger.warning(
"auth.clerk.profile.fetch_failed clerk_user_id=%s reason=sdk_exception "
"error_type=%s error=%s",
clerk_user_id,
exc.__class__.__name__,
str(exc)[:300],
) )
return None, None return None, None
@@ -399,25 +411,40 @@ async def _get_or_sync_user(
clerk_user_id: str, clerk_user_id: str,
claims: dict[str, object], claims: dict[str, object],
) -> User: ) -> User:
email, name = await _fetch_clerk_profile(clerk_user_id) claim_email = _extract_claim_email(claims)
logger.info( claim_name = _extract_claim_name(claims)
"auth.claims.parsed clerk_user_id=%s extracted_email=%s extracted_name=%s claims=%s",
clerk_user_id,
email,
name,
_claim_debug_snapshot(claims),
)
defaults: dict[str, object | None] = { defaults: dict[str, object | None] = {
"email": email, "email": claim_email,
"name": name, "name": claim_name,
} }
user, _created = await crud.get_or_create( user, created = await crud.get_or_create(
session, session,
User, User,
clerk_user_id=clerk_user_id, clerk_user_id=clerk_user_id,
defaults=defaults, defaults=defaults,
) )
profile_email: str | None = None
profile_name: str | None = None
# Avoid a network roundtrip to Clerk on every request once core profile
# fields are present in our DB.
should_fetch_profile = created or not user.email or not user.name
if should_fetch_profile:
profile_email, profile_name = await _fetch_clerk_profile(clerk_user_id)
email = profile_email or claim_email
name = profile_name or claim_name
logger.info(
"auth.claims.parsed clerk_user_id=%s extracted_email=%s extracted_name=%s "
"claim_email=%s claim_name=%s claims=%s",
clerk_user_id,
profile_email,
profile_name,
claim_email,
claim_name,
_claim_debug_snapshot(claims),
)
changed = False changed = False
if email and user.email != email: if email and user.email != email:
user.email = email user.email = email
@@ -433,7 +460,7 @@ async def _get_or_sync_user(
"auth.user.sync clerk_user_id=%s updated=%s claim_email=%s final_email=%s", "auth.user.sync clerk_user_id=%s updated=%s claim_email=%s final_email=%s",
clerk_user_id, clerk_user_id,
changed, changed,
_normalize_email(defaults.get("email")), _normalize_email(claim_email),
_normalize_email(user.email), _normalize_email(user.email),
) )
if not user.email: if not user.email: